Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/834#discussion_r75870493
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties
 ---
    @@ -131,8 +131,10 @@ nifi.web.jetty.threads=${nifi.web.jetty.threads}
     
     # security properties #
     nifi.sensitive.props.key=
    +nifi.sensitive.props.key.protected=${nifi.sensitive.props.key.protected}
    --- End diff --
    
    After building this PR, in conf/nifi.properties the property 
nifi.sensitive.props.key.protected was empty. I then filled in a value for 
nifi.sensitive.props.key and when I ran the toolkit it did not protect 
nifi.sensitive.props.key, I assume because it saw 
nifi.sensitive.props.key.protected was already there? I tested it again by 
first deleting the empty protected property and that time it did protect the 
sensitive properties key.
    
    Seems like nifi.sensitive.props.key.protected should not be here by 
default, or the toolkit should recognize an empty value and protect it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to