[
https://issues.apache.org/jira/browse/NIFI-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444876#comment-15444876
]
ASF GitHub Bot commented on NIFI-2686:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/965
NIFI-2686: Confusing log No hostnames specified
instanceDefinitions.isEmpty() was negate wrongly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-2686
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/965.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #965
----
commit def82e42597abcb82b064c6173008162ac89a40c
Author: Koji Kawamura <[email protected]>
Date: 2016-08-29T05:27:04Z
NIFI-2686: Confusing log No hostnames specified
instanceDefinitions.isEmpty() was negate wrongly.
----
> Confusing log message with tls-toolkit.sh "No hostnames specified"
> ------------------------------------------------------------------
>
> Key: NIFI-2686
> URL: https://issues.apache.org/jira/browse/NIFI-2686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Priority: Minor
>
> When I executed the following command (1), I saw a INFO log saying that "No
> hostnames specified" (2), even though I specified it with hostnames command
> argument.
> The corresponding java check code (3) becomes true if instanceDefinitions is
> not empty. I believe the log is meant for when hostname is not specified. The
> nifi.properties and key stores were successfully generated.
> (1) Executed command
> ./bin/tls-toolkit.sh standalone --hostnames 'localhost' --clientCertDn
> "CN=Koji.Kawamura,OU=NIFI" -o /tmp/generated-keys
> (2) INFO log
> {code}
> 2016-08-29 11:18:57,024 INFO [main] o.a.n.t.t.s.TlsToolkitStandalone No
> hostnames specified, not generating any host certificates or configuration.
> {code}
> (3) Check condition:
> {code: title=TlsToolkitStandalone.java line 135}
> if (!instanceDefinitions.isEmpty() && logger.isInfoEnabled()) {
> logger.info("No " + TlsToolkitStandaloneCommandLine.HOSTNAMES_ARG + "
> specified, not generating any host certificates or configuration.");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
