[
https://issues.apache.org/jira/browse/NIFI-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445925#comment-15445925
]
ASF GitHub Bot commented on NIFI-2686:
--------------------------------------
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/965
Ran contrib-check and then ran the tls-toolkit in standalone mode with and
without the --hostnames argument, behavior is now as expected.
Thanks @ijokarumawak !
+1
> Confusing log message with tls-toolkit.sh "No hostnames specified"
> ------------------------------------------------------------------
>
> Key: NIFI-2686
> URL: https://issues.apache.org/jira/browse/NIFI-2686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Priority: Trivial
>
> When I executed the following command (1), I saw a INFO log saying that "No
> hostnames specified" (2), even though I specified it with hostnames command
> argument.
> The corresponding java check code (3) becomes true if instanceDefinitions is
> not empty. I believe the log is meant for when hostname is not specified. The
> nifi.properties and key stores were successfully generated.
> (1) Executed command
> ./bin/tls-toolkit.sh standalone --hostnames 'localhost' --clientCertDn
> "CN=Koji.Kawamura,OU=NIFI" -o /tmp/generated-keys
> (2) INFO log
> {code}
> 2016-08-29 11:18:57,024 INFO [main] o.a.n.t.t.s.TlsToolkitStandalone No
> hostnames specified, not generating any host certificates or configuration.
> {code}
> (3) Check condition:
> {code: title=TlsToolkitStandalone.java line 135}
> if (!instanceDefinitions.isEmpty() && logger.isInfoEnabled()) {
> logger.info("No " + TlsToolkitStandaloneCommandLine.HOSTNAMES_ARG + "
> specified, not generating any host certificates or configuration.");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
