[ 
https://issues.apache.org/jira/browse/NIFI-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448283#comment-15448283
 ] 

ASF GitHub Bot commented on NIFI-2629:
--------------------------------------

GitHub user kirkalicious opened a pull request:

    https://github.com/apache/nifi/pull/969

    NIFI-2629 - Hide add property "+" in Processors, Controller Services and 
Reporting Tasks that don't allow dynamic properties

    Dto for Processor, Controller Service, and Reporting Task were modified to 
include a 'hasDynamicProperty' property, which is passed to the UI. Components 
that have a DynamicProperty annotation are true. False otherwise.
    
    Client side javascript was modified to show/hide the '+' icon in the 
'Properties' tab of the component configuration dialog.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kirkalicious/nifi NIFI-2629

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #969
    
----
commit ba0db0511da4675c0b6ca06a794d291ee250a163
Author: Kirk Tarou <[email protected]>
Date:   2016-08-23T04:14:59Z

    NIFI-2629 - Disable 'Add Property' icon in UI if the processor, controller
    service, or reporting task doesn't support dynamic properties

----


> Hide add property "+" in Processors, Controller Services and Reporting Tasks 
> that don't allow dynamic properties
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2629
>                 URL: https://issues.apache.org/jira/browse/NIFI-2629
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Core UI
>    Affects Versions: 0.7.0
>            Reporter: Kirk Tarou
>            Priority: Minor
>
> A few Processors, Controller Services and Reporting Tasks expect or allow 
> extra properties to be added on the 'Properties' tab in the Detail view. The 
> rest will show a "not a supported property" error.
> To avoid confusion, the new property "+" icon should be hidden if dynamic 
> properties are not allowed.
> The existence of a "DynamicProperty" annotation could be used as an indicator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to