[
https://issues.apache.org/jira/browse/NIFI-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448975#comment-15448975
]
ASF GitHub Bot commented on NIFI-2629:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/969
My only concern is the potential confusion over the API itself. This is
currently driven by `getSupportedDynamicPropertyDescriptor` which can
conditionally support a user defined property. The method is provided the
property name that the user entered and it's responsible for generating the
`PropertyDescriptor` for it. Because of this, the UI really can never know if
dynamic properties should be supported.
The `@DynamicProperty` annotation was added to assist with documentation.
We could take a firmer stance and require the annotation but that could result
in conflicting implementations (override
`getSupportedDynamicPropertyDescriptor` but not adding `@DynamicProperty`) as
@markap14 has pointed out. Once we've established this requirement however,
we'd ultimately be better off as we'd be sure that the dynamic properties are
documented. Because of this, I am in favor of the change though I also share
the hesitation of breaking existing custom processors and when/how we can
safely introduce it.
> Hide add property "+" in Processors, Controller Services and Reporting Tasks
> that don't allow dynamic properties
> ----------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-2629
> URL: https://issues.apache.org/jira/browse/NIFI-2629
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Core UI
> Affects Versions: 0.7.0
> Reporter: Kirk Tarou
> Priority: Minor
>
> A few Processors, Controller Services and Reporting Tasks expect or allow
> extra properties to be added on the 'Properties' tab in the Detail view. The
> rest will show a "not a supported property" error.
> To avoid confusion, the new property "+" icon should be hidden if dynamic
> properties are not allowed.
> The existence of a "DynamicProperty" annotation could be used as an indicator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
