[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

[pvillard31]

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/858
  
    Hey @trixpan 
    
    Few remarks, regarding the ``customValidate``, I'd suggest the following 
example:
    ````java
                results.add(new ValidationResult.Builder()
                        
.input(validationContext.getProperty(BATCH_SIZE).getValue())
                        .subject(QUERY_PARSER.getDisplayName())
                        .explanation("NONE parser does not support batching. 
Configure Batch Size to 1 or use another parser.")
                        .valid(false)
                        .build());
    ````
    
    This way instead of:
    '' validated against 'QUERY_PARSER' is invalid because NONE parser...
    
    I have:
    '500' validated against 'Results Parser' is invalid because NONE parser...
    
    Thoughts?
    
    Also, when I set the following configuration:
    <img width="759" alt="screen shot 2016-09-12 at 12 20 24 pm" 
src="https://cloud.githubusercontent.com/assets/11541012/18432639/5e696a8e-78e3-11e6-932c-a128eea3cc55.png";>
    
    I have the following result:
    ````
    --------------------------------------------------
    Standard FlowFile Attributes
    Key: 'entryDate'
        Value: 'Mon Sep 12 12:14:31 CEST 2016'
    Key: 'lineageStartDate'
        Value: 'Mon Sep 12 12:14:31 CEST 2016'
    Key: 'fileSize'
        Value: '0'
    FlowFile Attribute Map Content
    Key: 'enrich.whois.record0.group0'
        Value: 'Request must be in the form of 'origin a.b.c.d' or 'peer 
a.b.c.d' where a.b.c.d is a valid IPv4 address.
    '
    Key: 'filename'
        Value: '2616257872984957'
    Key: 'path'
        Value: './'
    Key: 'src.ip'
        Value: '123.36.123.1'
    Key: 'uuid'
        Value: '0bc829ab-3423-4f8d-bed3-dd3c8ee7db23'
    --------------------------------------------------
    ````
    
    Is that expected? I'd assume (with the processor configuration) that the 
result is not parsed in the same way but that the request is still performed 
correctly, no?
    
    Will continue reviewing later today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---