Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/986#discussion_r79215236
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ---
    @@ -114,6 +114,17 @@
             .sensitive(false)
             .build();
     
    +    public static final PropertyDescriptor VALIDATION_QUERY = new 
PropertyDescriptor.Builder()
    +            .name("Validation query")
    --- End diff --
    
    Please when adding new property, think about .displayName() and .name()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to