alopresto commented on a change in pull request #4377:
URL: https://github.com/apache/nifi/pull/4377#discussion_r456113916
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java
##########
@@ -657,11 +658,12 @@ public Response createAccessTokenFromTicket(@Context
HttpServletRequest httpServ
final String expirationFromProperties =
properties.getKerberosAuthenticationExpiration();
long expiration =
FormatUtils.getTimeDuration(expirationFromProperties, TimeUnit.MILLISECONDS);
- final String identity = authentication.getName();
- expiration = validateTokenExpiration(expiration, identity);
+ final String rawIdentity = authentication.getName();
+ expiration = validateTokenExpiration(expiration, rawIdentity);
Review comment:
I think the logging in `validateTokenExpiration` should use
`mappedIdentity` for better traceability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]