alopresto commented on a change in pull request #4377:
URL: https://github.com/apache/nifi/pull/4377#discussion_r456120213
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/dao/impl/StandardKeyDAO.java
##########
@@ -156,13 +156,13 @@ public Key createKey(final String identity) {
}
@Override
- public void deleteKeys(String identity) {
+ public Integer deleteKeys(String identity) {
PreparedStatement statement = null;
try {
// add each authority for the specified user
statement = connection.prepareStatement(DELETE_KEYS);
Review comment:
If we change the statement to use the `ID` rather than `IDENTITY`, this
should be consistent across all identity providers, correct?
`DELETE FROM KEY WHERE ID = 1` vs. `DELETE FROM KEY WHERE IDENTITY =
'admin'` (or possibly `IDENTITY = 'admin@REALM'`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
