mattyb149 commented on a change in pull request #4376:
URL: https://github.com/apache/nifi/pull/4376#discussion_r460155636



##########
File path: nifi-server-api/src/main/java/org/apache/nifi/NiFiServer.java
##########
@@ -33,6 +34,10 @@
 
     void setBundles(Bundle systemBundle, Set<Bundle> bundles);
 
+    void setNiFiProperties(NiFiProperties properties);
+
+    default void init() {}

Review comment:
       Makes sense, the `setBundles` method was already there so I just kept 
the approach consistent, but since they're all called in the same place 
(including `setExtensionMapping`), I can just move everything to a single 
`initialize` method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to