markap14 commented on pull request #4376: URL: https://github.com/apache/nifi/pull/4376#issuecomment-667166106
@mattyb149 thanks for the updates! I reviewed and code looks good. Did some quick tests and everything still seems to be working well. The only thing that gives me a bit of pause here is the naming convention. Currently, the naming for the new classes/packages/nars are very specific to MiNiFi. But this change itself does not introduce MiNiFi, but rather a headless version of nifi, which is a prereq, I would say, to a fully merging of MiNiFi. What do you think of naming these `nifi-headless-server-nar`, `HeadlessNiFiServer`, etc.? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
