jfrazee commented on pull request #4430: URL: https://github.com/apache/nifi/pull/4430#issuecomment-666653028
I have a very general concern about this change. The return type of `createBlobServiceClient()` changes from `CloudBlobClient` to `BlobServiceClient` in `AzureStorageUtils`, and `createQueueServiceClient()` changes from `CloudQueueClient` to `QueueServiceClient`, all of which are types from the Microsoft/Azure SDKs. Arguably, being public, it would have been better to not do this in the first place, but that's a benefit of hindsight. I see a few obvious choices with this: * Break it and don't worry about it since it's not necessarily supposed to be used elsewhere. * Break it but future proof it a little bit and wrap it in another class we control. * Leave the old ones in place for a little while and add new ones that may/may not be wrapped. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
