jfrazee commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463246197
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
##########
@@ -146,24 +142,46 @@ private AzureStorageUtils() {
}
/**
- * Create CloudBlobClient instance.
+ * Create BlobServiceClient instance.
* @param flowFile An incoming FlowFile can be used for NiFi Expression
Language evaluation to derive
* Account Name, Account Key or SAS Token. This can be
null if not available.
*/
- public static CloudBlobClient createCloudBlobClient(ProcessContext
context, ComponentLog logger, FlowFile flowFile) throws URISyntaxException {
+ public static BlobServiceClient createBlobServiceClient(PropertyContext
context, FlowFile flowFile) {
Review comment:
I made an overall comment on the PR. We wouldn't necessarily have to
have two sets of processors, but let's say we say we're just going to break it,
I think now would be a good time to improve things by wrapping it in something
we control.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
