hunyadi-dev commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r463604597
##########
File path: extensions/standard-processors/tests/integration/TailFileTest.cpp
##########
@@ -69,9 +70,11 @@ class TailFileTestHarness : public IntegrationBase {
}
void runAssertions() override {
- assert(LogTestController::getInstance().contains("5 flowfiles were
received from TailFile input") == true);
- assert(LogTestController::getInstance().contains("Looking for delimiter
0xA") == true);
- assert(LogTestController::getInstance().contains("li\\ne5") == true);
+ using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;
Review comment:
I counterpropose: This PR has been waiting for merge for quite a long
time, we should finally merge it unless there isa major flaw to be found in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
