hunyadi-dev commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r463610959



##########
File path: extensions/standard-processors/tests/integration/TailFileTest.cpp
##########
@@ -69,9 +70,11 @@ class TailFileTestHarness : public IntegrationBase {
   }
 
   void runAssertions() override {
-    assert(LogTestController::getInstance().contains("5 flowfiles were 
received from TailFile input") == true);
-    assert(LogTestController::getInstance().contains("Looking for delimiter 
0xA") == true);
-    assert(LogTestController::getInstance().contains("li\\ne5") == true);
+    using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;

Review comment:
       There is no conflict with main and all the jobs passed on Travis and 
Appveyor except from OSX 10.14.4. There is no compelling reason to have the GH 
Actions checks run them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to