szaszm commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469864618
########## File path: libminifi/include/io/Stream.h ########## @@ -0,0 +1,52 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace io { + +/** + * All streams serialize/deserialize in big-endian + */ +class Stream { + public: + virtual void close() {} + + virtual void seek(uint64_t offset) { + throw std::runtime_error("Seek is not supported"); + } + + virtual int initialize() { + return 1; + } + + virtual const uint8_t* getBuffer() const { + throw std::runtime_error("Not a buffered stream"); + } + virtual ~Stream() = default; +}; Review comment: I don't see the reason for the existence of this base class. - close: could be the destructor - seek: if it's not implemented, it probably shouldn't be part of the interface - initialize: same as seek, if it's not needed, it shouldn't be there - getBuffer: same - virtual dtor: if this class is gone, it can move to current derived classes ########## File path: libminifi/include/io/ZlibStream.h ########## @@ -62,12 +61,12 @@ class ZlibBaseStream : public BaseStream { ZlibStreamState state_{ZlibStreamState::UNINITIALIZED}; z_stream strm_{}; std::vector<uint8_t> outputBuffer_; + OutputStream* output_; Review comment: I think inner streams should be `gsl::not_null` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
