szaszm commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469923156
##########
File path: extensions/coap/tests/CoapC2VerifyHeartbeat.cpp
##########
@@ -132,18 +132,18 @@ class VerifyCoAPServer : public CoapIntegrationBase {
{
// should result in valid operation
- minifi::io::BaseStream stream;
+ minifi::io::BufferStream stream;
uint16_t version = 0, size = 1;
uint8_t operation = 1;
stream.write(version);
stream.write(size);
stream.write(&operation, 1);
- stream.writeUTF("id");
- stream.writeUTF("operand");
+ stream.write("id");
+ stream.write("operand");
- uint8_t *data = new uint8_t[stream.getSize()];
- memcpy(data, stream.getBuffer(), stream.getSize());
- minifi::coap::CoapResponse response(205, std::unique_ptr<uint8_t>(data),
stream.getSize());
+ uint8_t *data = new uint8_t[stream.size()];
Review comment:
Our `utils::make_unique` doesn't support arrays yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
