hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -342,6 +352,50 @@ std::shared_ptr<core::FlowFile>
ZipMerge::merge(core::ProcessContext *context, c
return flowFile;
}
+void AttributeMerger::mergeAttributes(core::ProcessSession *session,
std::shared_ptr<core::FlowFile> &merge_flow) {
+ for (const auto& pair : getMergedAttributes()) {
+ session->putAttribute(merge_flow, pair.first, pair.second);
+ }
+}
+
+std::map<std::string, std::string> AttributeMerger::getMergedAttributes() {
+ std::map<std::string, std::string> merged_attributes;
Review comment:
Maybe `std::accumulate` could make this simpler:
```c++
if(flows_.empty()) {
return {}
}
const auto merge_attributes = [&] (
const std::map<std::string, std::string>& merged_attributes,
const std::shared_ptr<core::FlowFile>& flow)
{ return processFlowFile(flow, merged_attributes); }
return std::accumulate(std::next(flows_.cbegin()), flows.cend(),
flows_.begin()->getAttributes(), merge_attributes);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
