lordgamez commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470065882
##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -342,6 +352,50 @@ std::shared_ptr<core::FlowFile>
ZipMerge::merge(core::ProcessContext *context, c
return flowFile;
}
+void AttributeMerger::mergeAttributes(core::ProcessSession *session,
std::shared_ptr<core::FlowFile> &merge_flow) {
+ for (const auto& pair : getMergedAttributes()) {
+ session->putAttribute(merge_flow, pair.first, pair.second);
+ }
+}
+
+std::map<std::string, std::string> AttributeMerger::getMergedAttributes() {
+ std::map<std::string, std::string> merged_attributes;
Review comment:
I tried this solution before as @szaszm also suggested it, and it was
working and was a quite elegant solution, but I dropped it as the
[cppreference](https://en.cppreference.com/w/cpp/algorithm/accumulate)
suggested that std::move is only used in its implementation from C++20, so
copying every temporal map result when there is a large number of flow files
may be slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
