mattyb149 commented on a change in pull request #194:
URL: https://github.com/apache/nifi-minifi/pull/194#discussion_r478659134
##########
File path:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
##########
@@ -257,7 +257,9 @@ protected static void writeNiFiProperties(ConfigSchema
configSchema, OutputStrea
orderedProperties.setProperty("nifi.web.jetty.working.directory",
"./work/jetty");
orderedProperties.setProperty("nifi.web.jetty.threads", "200");
- orderedProperties.setProperty("nifi.sensitive.props.key",
sensitiveProperties.getKey(), System.lineSeparator() + "# security properties
#");
+ final String sensitivePropertiesKey = sensitiveProperties.getKey();
+ final String notnullSensitivePropertiesKey =
sensitivePropertiesKey != null ? sensitivePropertiesKey : "";
Review comment:
Can you add a unit test for this? I think you can use a copy of the
bootstrap.conf from minifi-bootstrap/src/test/resources/MINIFI-516 but just set
the keystoreType property mentioned in the Jira. It might result in a later
error, but if it's not an NPE it could be expected.
Actually you could just set the keystoreType property in the existing
bootstrap.conf and ensure that `ConfigTransformerTest.checkSSLOverrides()`
passes with your fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
