kevdoran commented on a change in pull request #194:
URL: https://github.com/apache/nifi-minifi/pull/194#discussion_r478668580
##########
File path:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
##########
@@ -257,7 +257,9 @@ protected static void writeNiFiProperties(ConfigSchema
configSchema, OutputStrea
orderedProperties.setProperty("nifi.web.jetty.working.directory",
"./work/jetty");
orderedProperties.setProperty("nifi.web.jetty.threads", "200");
- orderedProperties.setProperty("nifi.sensitive.props.key",
sensitiveProperties.getKey(), System.lineSeparator() + "# security properties
#");
+ final String sensitivePropertiesKey = sensitiveProperties.getKey();
+ final String notnullSensitivePropertiesKey =
sensitivePropertiesKey != null ? sensitivePropertiesKey : "";
Review comment:
@mattyb149 I did both. I modified
ConfigTransformerTest.checkSSLOverrides() per your suggestion, and also added a
new unit test that would have triggered the NPE before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
