arpadboda commented on a change in pull request #878:
URL: https://github.com/apache/nifi-minifi-cpp/pull/878#discussion_r479240154
##########
File path: docker/DockerVerify.sh
##########
@@ -17,6 +17,12 @@
set -e
+if [[ $# -lt 1 ]]; then
+ echo "Usage:"
+ echo " ./DockerVerify.sh <MINIFI_VERSION>"
Review comment:
👍
##########
File path: docker/test/integration/minifi/__init__.py
##########
@@ -413,7 +426,7 @@ def __init__(self,
self.controller_services = controller_services
self.schedule = {
- 'scheduling strategy': 'EVENT_DRIVEN',
+ 'scheduling strategy': 'TIMER_DRIVEN',
Review comment:
👍 by default, but longer term it would be nice to make it configurable.
Sources should definitely be timer driven, in case of consumers (like
publishkafka), it's not that straight forward.
##########
File path: docker/test/integration/minifi/test/__init__.py
##########
@@ -166,20 +184,33 @@ def log_nifi_output(self):
stats = container.stats(stream=False)
logging.info('Container stats:\n%s', stats)
- def check_output(self, timeout=5, **kwargs):
Review comment:
I think having kwargs here is useful, as kwargs can contain subdir as a
key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
