lordgamez commented on a change in pull request #878:
URL: https://github.com/apache/nifi-minifi-cpp/pull/878#discussion_r479631863
##########
File path: docker/test/integration/minifi/test/__init__.py
##########
@@ -166,20 +184,33 @@ def log_nifi_output(self):
stats = container.stats(stream=False)
logging.info('Container stats:\n%s', stats)
- def check_output(self, timeout=5, **kwargs):
Review comment:
I removed it as `subdir` was the only kwarg we used and replaced it with
the `subdir` parameter with empty default value, which is a more explicit
signature to see what args we can use.
` def check_output(self, timeout=5, subdir=''):`
We can still use it as a kwarg when calling the check_output.
` assert cluster.check_output(30, subdir='success')`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
