hunyadi-dev commented on a change in pull request #882:
URL: https://github.com/apache/nifi-minifi-cpp/pull/882#discussion_r479627106
##########
File path: docker/DockerBuild.sh
##########
@@ -16,23 +17,28 @@
# under the License.
#
-#!/bin/bash
-
# Set env vars.
UID_ARG=$1
GID_ARG=$2
MINIFI_VERSION=$3
MINIFI_SOURCE_CODE=$4
CMAKE_SOURCE_DIR=$5
+IMAGE_TYPE=${6:-release}
+
+if [ "${IMAGE_TYPE}" == "release" ]; then
+ TAG=
+else
+ TAG="${IMAGE_TYPE}-"
+fi
Review comment:
This could be a bit simpler as
```sh
unset TAG
if [ "${IMAGE_TYPE}" != "release" ]; then
TAG="${IMAGE_TYPE}-"
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
