szaszm commented on a change in pull request #882:
URL: https://github.com/apache/nifi-minifi-cpp/pull/882#discussion_r481083007
##########
File path: docker/DockerBuild.sh
##########
@@ -47,16 +52,17 @@ rsync -avr \
--exclude '/extensions/expression-language/position.hh' \
--exclude '/extensions/expression-language/stack.hh' \
--delete \
- $CMAKE_SOURCE_DIR/ \
- $CMAKE_SOURCE_DIR/docker/minificppsource/
+ "${CMAKE_SOURCE_DIR}/" \
+ "${CMAKE_SOURCE_DIR}/docker/minificppsource/"
-DOCKER_COMMAND="docker build --build-arg UID=$UID_ARG \
- --build-arg GID=$GID_ARG \
- --build-arg MINIFI_VERSION=$MINIFI_VERSION \
- --build-arg
MINIFI_SOURCE_CODE=$MINIFI_SOURCE_CODE \
+DOCKER_COMMAND="docker build --build-arg UID=${UID_ARG} \
+ --build-arg GID=${GID_ARG} \
+ --build-arg MINIFI_VERSION=${MINIFI_VERSION} \
+ --build-arg
MINIFI_SOURCE_CODE=${MINIFI_SOURCE_CODE} \
+ --target ${IMAGE_TYPE} \
-t \
- apacheminificpp:$MINIFI_VERSION ."
-echo "Docker Command: '$DOCKER_COMMAND'"
-${DOCKER_COMMAND}
+ apacheminificpp:${TAG}${MINIFI_VERSION} ."
+echo "Docker Command: '${DOCKER_COMMAND}'"
+DOCKER_BUILDKIT=1 ${DOCKER_COMMAND}
-rm -rf $CMAKE_SOURCE_DIR/docker/minificppsource
+rm -rf "${CMAKE_SOURCE_DIR}/docker/minificppsource"
Review comment:
I appreciate the fixed support for spaces in the source path. :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
