lordgamez commented on pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683664280
> > > > Is there a plan/jira ticket for also running these checks (with possibly an additionally shellcheck for shell files and flake8/pylint check for python files) in the CI as github actions as well? > > > > > > > > > I am unaware of such plans. > > > > > > I would suggest integrating this linter check to github actions after they are fixed just to have them run automatically preventing further violations by any PRs. Or it can be done in a separate jira task if you prefer. I could open a new ticket for this if you would prefer to do it separately and I can open separate tickets for the pylint and shellcheck as well. > > It is in fact integrated, we have a `linter` build system target (eg. `make linter`) which is built on at least one of the CI jobs. The directories to be checked were incorrectly specified, for this I have a WIP PR here: #851 > Once all of the fixes are merged, we can merge it and therefore improve our linter check coverage. > > I can only do a few of these types of PR-s at the same time as fixing conflicts between them would most likely take up more time than doing the fixup. > > Doing the changes themselves is easy as I already have scripts ready to fix them, however, there are a lot of changes to do (I would estimate it to take 30-40 PRs (!)): > > ``` > cat linter_errors.txt | cut -d":" -f3- | sort | uniq -c | sort | wc -l > 676 > # Errors that occur at least 10 times: > cat linter_errors.txt | cut -d":" -f3- | sort | uniq -c | egrep -v "^\s*[1-9] " | wc -l > 41 > ``` > > We are in no rush with this though. Thanks for the heads up! Now I see that the linter checks are part of the macos-xcode jobs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
