hunyadi-dev commented on a change in pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484263554



##########
File path: extensions/sftp/tests/FetchSFTPTests.cpp
##########
@@ -142,7 +142,7 @@ class FetchSFTPTestsFixture {
     std::fstream file;
     std::stringstream ss;
     ss << src_dir << "/vfs/" << relative_path;
-    
utils::file::FileUtils::create_dir(utils::file::FileUtils::get_parent_path(ss.str()));
 // TODO
+    
utils::file::FileUtils::create_dir(utils::file::FileUtils::get_parent_path(ss.str()));
  // TODO

Review comment:
       I would refrain from deleting `TODO`-s, someone might know what they 
stand for. I could not trace it back what it could mean, it was added along 
with the function by Daniel Bakai.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to