adamdebreceni commented on a change in pull request #865:
URL: https://github.com/apache/nifi-minifi-cpp/pull/865#discussion_r481811674
##########
File path: libminifi/src/utils/Id.cpp
##########
@@ -48,6 +48,8 @@ namespace nifi {
namespace minifi {
namespace utils {
+const char* Identifier::UUID_FORMAT_STRING =
"%02hhx%02hhx%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx";
Review comment:
would `constexpr` allow us to make it an in-class initializer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
