adamdebreceni commented on a change in pull request #865:
URL: https://github.com/apache/nifi-minifi-cpp/pull/865#discussion_r489385340
##########
File path: libminifi/include/utils/Id.h
##########
@@ -107,9 +107,12 @@ class IdentifierBase {
typedef uint8_t UUID_FIELD[16];
class Identifier : public IdentifierBase<UUID_FIELD, std::string> {
+ static constexpr const char* UUID_FORMAT_STRING =
"%02hhx%02hhx%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx";
Review comment:
I believe it is not necessary since UUID_FORMAT_STRING is not odr-used
> A variable whose name appears as a potentially-evaluated expression is
odr-used unless it is an
object that satisfies the requirements for appearing in a constant
expression (5.19) and the lvalue-to-rvalue
conversion (4.1) is immediately applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
