hunyadi-dev opened a new pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890
**It is easiest to review this PR on a per-commit basis.** The FlowController methods: `start`, `stop`, `load`, `unload` (and maybe even `waitUnload`), were strongly coupled and were controlled through FlowController states that made it difficult to argue about what goes on in each of them. `load` had two versions with only minor differences, one reload (with a few extra steps) and one non-reload. The version that did the reload was only called during `applyConfiguration`, so I moved the extra behaviour required there (and renamed the related functions accordingly to prove there were no other instances of calling reload). `start` was changing the state of `initialized_` read by only itself and `load`, but it is easy to argue that `start` is never called twice and `load` is never called without a preceeding `start`, proving this variable clutter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
