hunyadi-dev commented on a change in pull request #890:
URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484382473
##########
File path: libminifi/include/FlowController.h
##########
@@ -338,6 +335,10 @@ class FlowController : public
core::controller::ControllerServiceProvider, publi
utils::optional<std::chrono::milliseconds>
loadShutdownTimeoutFromConfiguration();
private:
+ void restartThreadPool();
+ void initializeUninitializedSchedulers();
+ void reinitializeSchedulersWithNewThreadPool();
Review comment:
It calls `ThreadPool::shutdown` which clears any running activities,
joins all threads, and clears all worker threads as well (also resets config).
The `ThreadPool` object is not new as in newly allocated, but new as the pool
brand new threads.
I agree that it is not the best name, will rename it to
`reinitializeSchedulersWithClearedThreadPool()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
