szaszm edited a comment on pull request #900: URL: https://github.com/apache/nifi-minifi-cpp/pull/900#issuecomment-690302679
There are a bunch of changes changing "pass shared_ptr by value" to "pass shared_ptr by const ref". Why? If we intend to share ownership, it should be passed by value. If we just want to use the underlying object, passing a reference or raw pointer to that is probably better. Related very incomplete guideline: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-sharedptrparam-const ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
