szaszm commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486988154
##########
File path: extensions/bustache/ApplyTemplate.h
##########
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback : public OutputStreamCallback {
public:
WriteCallback(const std::string &templateFile, const
std::shared_ptr<core::FlowFile> &flow_file);
- int64_t process(std::shared_ptr<io::BaseStream> stream);
+ int64_t process(const std::shared_ptr<io::BaseStream>& stream);
Review comment:
Understood. I'd go for 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
