adamdebreceni commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r487039994
##########
File path: extensions/bustache/ApplyTemplate.h
##########
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback : public OutputStreamCallback {
public:
WriteCallback(const std::string &templateFile, const
std::shared_ptr<core::FlowFile> &flow_file);
- int64_t process(std::shared_ptr<io::BaseStream> stream);
+ int64_t process(const std::shared_ptr<io::BaseStream>& stream);
Review comment:
as it turns out there are a number of implementations that store the
stream, so that callbacks may access it, e.g. `CompressContent::WriteCallback`,
`JniByteInputStream`, `FocusArchiveEntry::ReadCallback`,
`ArchiveMerge::WriteCallback`, `UnfocusArchiveEntry::WriteCallback`,
`LuaInputStreamCallback`, `PyOutputStreamCallback`, moreover the hash functions
in `HashContent` expect a `shared_ptr`
based on this coupled with the diff explosion that would result from
rewriting all the `stream->write` to `stream.write`, I propose we leave this be
for now, and return to it in a later PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
