adamdebreceni commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r500993717
##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -72,10 +74,12 @@ core::Property MergeContent::AttributeStrategy(
"only the attributes that exist on all FlowFiles in the
bundle, with the same value, will be preserved.")
->withAllowableValues<std::string>({merge_content_options::ATTRIBUTE_STRATEGY_KEEP_COMMON,
merge_content_options::ATTRIBUTE_STRATEGY_KEEP_ALL_UNIQUE})
->withDefaultValue(merge_content_options::ATTRIBUTE_STRATEGY_KEEP_COMMON)->build());
+core::Property MergeContent::FlowFileSerializer(
+ core::PropertyBuilder::createProperty("Flow File Serializer")
+ ->withDescription("Determines how to flow files should be serialized before
merging")
+
->withAllowableValues<std::string>({merge_content_options::SERIALIZER_PAYLOAD,
merge_content_options::SERIALIZER_FLOW_FILE_V3})
+ ->withDefaultValue(merge_content_options::SERIALIZER_PAYLOAD)->build());
Review comment:
imo the idea of WHAT we want to merge, and HOW we want to merge are
orthogonal, here `Flow File Serializer` answers the WHAT and `Merge Format`
answers the HOW
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
