szaszm commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r499683494
##########
File path: libminifi/include/properties/Properties.h
##########
@@ -65,7 +65,7 @@ class Properties {
* @param value value in which to place the map's stored property value
* @returns true if found, false otherwise.
*/
- bool get(const std::string &key, std::string &value) const;
+ bool getString(const std::string &key, std::string &value) const;
Review comment:
Instead of renaming this, the updated `Configure` should use base class
qualified function call. The `String` part of `getString` is redundant
information in context of `Properties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
