szaszm commented on a change in pull request #914: URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r501827638
########## File path: encrypt-config/CMakeLists.txt ########## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +file(GLOB ENCRYPT_CONFIG_FILES "*.cpp") +add_executable(encrypt-config "${ENCRYPT_CONFIG_FILES}") +target_include_directories(encrypt-config PRIVATE ../libminifi/include ../thirdparty/cxxopts/include) +target_wholearchive_library(encrypt-config minifi) +target_link_libraries(encrypt-config cxxopts libsodium) +set_target_properties(encrypt-config PROPERTIES OUTPUT_NAME encrypt-config) +install(TARGETS encrypt-config RUNTIME DESTINATION bin COMPONENT bin) Review comment: Multi configuration generators (visual studio) don't save the last build type in the cache, so cpack apparently has no way of knowing that it has to get the binary from the Debug/RelWithDebInfo directory and defaults to Release (the first one AFAIK). Not sure why the issue only happens with `install(TARGETS)`, but the fix is to append pass `-C <configuration>` to cpack. Could you add this to `win_build_vs.bat`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
