adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r503739298
##########
File path: extensions/libarchive/BinFiles.cpp
##########
@@ -259,9 +279,13 @@ void BinFiles::onTrigger(const
std::shared_ptr<core::ProcessContext> &context, c
}
}
- auto flow = session->get();
+ for (size_t i = 0; i < batchSize_; ++i) {
+ auto flow = session->get();
+
+ if (flow == nullptr) {
+ break;
Review comment:
the problem with yielding is that, this processor can function correctly
even if there are no incoming flowFiles (it can still emit already processed
merged files)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
