adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r503763908
##########
File path: extensions/libarchive/CompressContent.cpp
##########
@@ -45,11 +45,11 @@ core::Property CompressContent::CompressFormat(
core::PropertyBuilder::createProperty("Compression
Format")->withDescription("The compression format to use.")
->isRequired(false)
->withAllowableValues<std::string>({
- COMPRESSION_FORMAT_ATTRIBUTE,
- COMPRESSION_FORMAT_GZIP,
- COMPRESSION_FORMAT_BZIP2,
- COMPRESSION_FORMAT_XZ_LZMA2,
-
COMPRESSION_FORMAT_LZMA})->withDefaultValue(COMPRESSION_FORMAT_ATTRIBUTE)->build());
+ toString(ExtendedCompressionFormat::USE_MIME_TYPE),
+ toString(CompressionFormat::GZIP),
+ toString(CompressionFormat::BZIP2),
+ toString(CompressionFormat::XZ_LZMA2),
+
toString(CompressionFormat::LZMA)})->withDefaultValue(toString(ExtendedCompressionFormat::USE_MIME_TYPE))->build());
Review comment:
done, added means to query all enum representations, i.e.
`ExtendedCompressionFormat::values()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
