[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

[GitBox]

arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507733162



##########
File path: libminifi/include/utils/Id.h
##########
@@ -65,10 +67,11 @@ class Identifier {
 
   bool operator!=(const Identifier& other) const;
   bool operator==(const Identifier& other) const;
+  bool operator<(const Identifier& other) const;
 
   bool isNil() const;
 
-  std::string to_string() const;
+  SmallString<36> to_string() const;

Review comment:
       I wonder if we could typedef this somewhere to UUIDString or something 
talkative, rather then just the length referring to the content. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org