szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507750504
##########
File path: libminifi/include/utils/Id.h
##########
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool operator==(const Identifier& other) const;
+ bool operator<(const Identifier& other) const;
bool isNil() const;
- std::string to_string() const;
+ SmallString<36> to_string() const;
Review comment:
I disagree with this idea because the intent of the function is to
return a string, not to return an UUIDString, the same way `std::to_string`
doesn't return IntStrings and LongStrings, but just `std::string`.
In general I think these typedefs can easily obscure the code if not used
with care. There doesn't seem to be an industry-wide discussion about this, so
this is purely my opinion, not a guideline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
