adamdebreceni commented on a change in pull request #914: URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r508332045
########## File path: encrypt-config/ConfigFileEncryptor.cpp ########## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "ConfigFileEncryptor.h" + +#include <iostream> +#include <string> + +#include "utils/StringUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace encrypt_config { + +uint32_t encryptSensitivePropertiesInFile(ConfigFile& config_file, const utils::crypto::Bytes& encryption_key) { + int num_properties_encrypted = 0; + + for (const auto& property_key : config_file.getSensitiveProperties()) { + utils::optional<std::string> property_value = config_file.getValue(property_key); + if (!property_value) { continue; } + + std::string encryption_type_key = property_key + ".protected"; + utils::optional<std::string> encryption_type = config_file.getValue(encryption_type_key); + + if (!encryption_type || encryption_type->empty() || *encryption_type == "plaintext") { Review comment: what if the user accidentally tries to encrypt a file that already contains encrypted values with a different encryption key, should they get a warning? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
