lordgamez commented on a change in pull request #915:
URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509310005



##########
File path: PROCESSORS.md
##########
@@ -1125,3 +1126,40 @@ In the list below, the names of required properties 
appear in bold. Any other pr
 |success|All files are routed to success|
 
 
+## PutS3Object
+
+### Description
+
+Puts FlowFiles to an Amazon S3 Bucket. The upload uses either the PutS3Object 
method. The PutS3Object method send the file in a single synchronous call, but 
it has a 5GB size limit. Larger files sent using the multipart upload methods 
are currently not supported. The AWS libraries select an endpoint URL based on 
the AWS region, but this can be overridden with the 'Endpoint Override URL' 
property for use with other S3-compatible endpoints. The S3 API specifies that 
the maximum file size for a PutS3Object upload is 5GB.
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
+
+| Name | Default Value | Allowable Values | Description |
+| - | - | - | - |
+|**Object Key**|${filename}||The key of the S3 object<br/>**Supports 
Expression Language: true**|

Review comment:
       Sounds good to me, I am not familiar how common are agents without EL 
support, but it's reasonable to support those as well. In that case the access 
control properties should lose the default values too, as if those are invalid 
the put operation fails on AWS. Those properties are not mandatory so we can 
have empty defaults if that sounds okay?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to