lordgamez commented on a change in pull request #915:
URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509427851
##########
File path: cmake/BundledAwsSdkCpp.cmake
##########
@@ -23,8 +23,8 @@ function(use_bundled_libaws SOURCE_DIR BINARY_DIR)
set(SUFFIX "a")
endif()
set(BYPRODUCTS
- "lib/libaws-cpp-sdk-core.${SUFFIX}"
- "lib/libaws-cpp-sdk-s3.${SUFFIX}")
+ "${CMAKE_INSTALL_LIBDIR}/libaws-cpp-sdk-core.${SUFFIX}"
Review comment:
Added it in
[8a05f1a](https://github.com/apache/nifi-minifi-cpp/pull/915/commits/8a05f1a3821aabe6a72607d9dae28a418dd9f57d)
and I also found some problems with the AWS build on Windows. Fixed them in
[42eb471](https://github.com/apache/nifi-minifi-cpp/pull/915/commits/42eb471011efb7c93e13a553d6a04f129ccd1439)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
