tpalfy commented on a change in pull request #4655:
URL: https://github.com/apache/nifi/pull/4655#discussion_r522381602
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java
##########
@@ -220,6 +221,19 @@
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+ static final PropertyDescriptor REREAD_ON_NUL = new
PropertyDescriptor.Builder()
+ .name("reread-on-nul")
+ .displayName("Reread when NUL encountered")
+ .description("If this option is set to 'true', when a NUL
character is read, the processor will yield and try to read the same part again
later. "
+ + "The purpose of this flag is to allow users to handle cases
where reading a file may return temporary NUL values. "
+ + "NFS for example may send file contents out of order. In
this case the missing parts are temporarily replaced by NUL values. "
Review comment:
To me "temporarily replaced" feels a bit better as it conveys the notion
of "switching" the value with something else for a time.
"filled up" better conveys the notion of doing this up to a certain point. I
consider the first notion more important but debatable.
If this comment gets another vote I'll change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
