tpalfy commented on a change in pull request #4655:
URL: https://github.com/apache/nifi/pull/4655#discussion_r522945238
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java
##########
@@ -610,7 +625,13 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
for (String tailFile : states.keySet()) {
- processTailFile(context, session, tailFile);
+ try {
+ processTailFile(context, session, tailFile);
+ } catch (NulCharacterEncounteredException e) {
+ getLogger().warn("NUL character encountered in " + tailFile +
" and '" + REREAD_ON_NUL.getDisplayName() + "' is set to 'true', yielding.");
+ context.yield();
+ return;
Review comment:
I'll update the description of the property to note this behaviour.
If the behaviour itself is deemed to be fine, I'd rather not add a ticket
(that would probably wouldn't be taken care of anytime soon).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
