markap14 commented on pull request #4655: URL: https://github.com/apache/nifi/pull/4655#issuecomment-728297905
Thanks for the fix @tpalfy! Code changes look good to me. Added unit tests help. All existing tests still pass, so I'm a +1. I made a comment in the review. You may well already be familiar with the pattern but it's a pattern that wasn't possible until somewhat recently so i figured i'd mention it. In any case, I approve the changes. Will merged. Thanks! And a big thank you to @simonbence for reviewing as well! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
