adamdebreceni commented on a change in pull request #957:
URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r541016032



##########
File path: libminifi/include/properties/Properties.h
##########
@@ -45,19 +51,19 @@ class Properties {
 
   // Clear the load config
   void clear() {
-    std::lock_guard<std::mutex> lock(mutex_);
+    std::lock_guard<std::recursive_mutex> lock(mutex_);

Review comment:
       forgot why we needed the `recursive_mutex`, add explanation pls




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to