adamdebreceni commented on a change in pull request #957:
URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551922305
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -499,8 +507,8 @@ class C2UpdateHandler : public ServerAwareHandler {
}
std::atomic<size_t> calls_{0};
Review comment:
made it protected and added getter
##########
File path: libminifi/include/properties/Properties.h
##########
@@ -51,13 +57,13 @@ class Properties {
// Set the config value
void set(const std::string &key, const std::string &value) {
std::lock_guard<std::mutex> lock(mutex_);
- properties_[key] = value;
+ properties_[key] = PropertyValue{value, true};
dirty_ = true;
}
// Check whether the config value existed
- bool has(std::string key) const {
+ bool has(const std::string& key) const {
std::lock_guard<std::mutex> lock(mutex_);
- return properties_.count(key) > 0;
+ return properties_.find(key) != properties_.end();
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
