exceptionfactory commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r548225218
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -657,18 +661,16 @@ class ConfigEncryptionTool {
/**
* Loads the flow definition from the provided file path, handling the
GZIP file compression. Unlike {@link #loadLoginIdentityProviders()} this method
does not decrypt the content (for performance and separation of concern
reasons).
*
- * @return the file content
+ * @param The path to the XML file
+ * @return The file content
* @throw IOException if the flow.xml.gz file cannot be read
*/
- private String loadFlowXml() throws IOException {
+ private InputStream loadFlowXml(String flowXmlPath) throws IOException {
Review comment:
The parameter `flowXmlPath` should probably be renamed since it shadows
the static `flowXmlPath` variable declared in the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
